Skip to content

[tools] fix EXEC_PATH exists, but the CC does not.#8830

Merged
mysterywolf merged 1 commit intomasterfrom
env_cc
Apr 20, 2024
Merged

[tools] fix EXEC_PATH exists, but the CC does not.#8830
mysterywolf merged 1 commit intomasterfrom
env_cc

Conversation

@BernardXiong
Copy link
Copy Markdown
Member

@BernardXiong BernardXiong commented Apr 20, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

修正EXEC_PATH存在，但EXEC_PATH/CC不存在的问题 <Linux下存在这样的问题>。

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf merged commit 582d11f into master Apr 20, 2024
@mysterywolf mysterywolf deleted the env_cc branch April 20, 2024 18:39
mysterywolf
mysterywolf reviewed May 5, 2024
View reviewed changes
Comment thread tools/building.py

# auto change the 'RTT_EXEC_PATH' when 'rtconfig.EXEC_PATH' get failed
if not os.path.exists(rtconfig.EXEC_PATH):
if not os.path.exists(os.path.join(rtconfig.EXEC_PATH, rtconfig.CC)):
Copy link
Copy Markdown
Member

@mysterywolf mysterywolf May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这句话改的有问题，这么改之后导致env scons的时候找不到已经设置的RTT_EXEC_PATH路径，精确定位到这句话导致的。

Copy link
Copy Markdown
Member

@mysterywolf mysterywolf May 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证环境 Env for windows 1.5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mysterywolf mysterywolf mysterywolf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BernardXiong @mysterywolf